Fix a crash in icon handling
authorMatthias Clasen <mclasen@redhat.com>
Tue, 15 Oct 2013 12:04:25 +0000 (08:04 -0400)
committerMatthias Clasen <mclasen@redhat.com>
Tue, 15 Oct 2013 12:04:25 +0000 (08:04 -0400)
The load_error was freed in two places.
Fix based on a patch in
https://bugzilla.gnome.org/show_bug.cgi?id=709967

gtk/gtkicontheme.c

index fad7ff4bdabf6fc494f6ce1312d6c99c96d52aa7..7fc76bf703c75b96aee8444ea46c97f24ff284c8 100644 (file)
@@ -3873,12 +3873,17 @@ gtk_icon_info_load_icon (GtkIconInfo *icon_info,
   if (!icon_info_ensure_scale_and_pixbuf (icon_info, FALSE))
     {
       if (icon_info->load_error)
-        g_propagate_error (error, icon_info->load_error);
+        {
+          if (*error)
+            *error = g_error_copy (icon_info->load_error);
+        }
       else
-        g_set_error_literal (error,  
-                             GTK_ICON_THEME_ERROR,  
-                             GTK_ICON_THEME_NOT_FOUND,
-                             _("Failed to load icon"));
+        {
+          g_set_error_literal (error,  
+                               GTK_ICON_THEME_ERROR,  
+                               GTK_ICON_THEME_NOT_FOUND,
+                               _("Failed to load icon"));
+        }
  
       return NULL;
     }